[all-commits] [llvm/llvm-project] 53727b: [gn build] Use lib_dirs instead of qualified path ...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53727b48fde1c275476e7531a0731bb1d9842dc5
      https://github.com/llvm/llvm-project/commit/53727b48fde1c275476e7531a0731bb1d9842dc5
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M llvm/utils/gn/build/toolchain/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

  Log Message:
  -----------
  [gn build] Use lib_dirs instead of qualified path in libs for diaguids.lib

Follow-up to D109708: Using lib_dirs means this will work with ancient gn binaries.

Change the toolchain definitions to make lib_dirs have the right effect, and
pull out lib_switch of each of the tools while here.

This means we now do pass /LIBPATH: to link.exe, but since we invoke it directly
and not through clang-cl, this doesn't actually require D109624. And since this
is built in to GN, we don't need a config to push the flag to dependents.

This is arguably a bit more idiomatic, and it doesn't require folks to update
their GN binaries. No effective behavior change.

Differential Revision: https://reviews.llvm.org/D109763