[all-commits] [llvm/llvm-project] f78f61: [llvm cmake] replace tabs with spaces in config-ix...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f78f613bb74ca837be36efcc72105c3c2d54b4f3
      https://github.com/llvm/llvm-project/commit/f78f613bb74ca837be36efcc72105c3c2d54b4f3
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M llvm/cmake/config-ix.cmake

  Log Message:
  -----------
  [llvm cmake] replace tabs with spaces in config-ix.cmake


  Commit: 8cfab5de13a8ec3a2ffccb1b94b0165512a33552
      https://github.com/llvm/llvm-project/commit/8cfab5de13a8ec3a2ffccb1b94b0165512a33552
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M compiler-rt/cmake/config-ix.cmake
    M llvm/cmake/config-ix.cmake
    M llvm/cmake/modules/HandleLLVMOptions.cmake
    M llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/enable_dia.gni
    M llvm/utils/sysroot.py

  Log Message:
  -----------
  [Windows build] Use "DIA SDK" in sysroot

This updates llvm/utils/sysroot.py to include the "DIA SDK" folder in the
sysroot.

It also updates the build to look for the DIA SDK there if a sysroot is set.

This requires moving LLVM_WINSYSROOT to config-ix.cmake.

For the GN build, I chose to pass a qualified path to diaguids in libs instead
of pushing a config with a `/libpath:` flag. The former requires a GN with
https://gn-review.googlesource.com/c/gn/+/12200, the latter requires D109624.
The former is more like the cmake build, arguably a bit simpler, and it's
easier to check for the wrong GN revision and easier to update GN.

Differential Revision: https://reviews.llvm.org/D109708


Compare: https://github.com/llvm/llvm-project/compare/09dc454b00b8...8cfab5de13a8