[all-commits] [llvm/llvm-project] 993f60: [clang][deps] Sanitize both instances of Diagnosti...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 993f60ae32de001ac9ac1ff512f2adf339e265c8
      https://github.com/llvm/llvm-project/commit/993f60ae32de001ac9ac1ff512f2adf339e265c8
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
    M clang/test/ClangScanDeps/error.cpp

  Log Message:
  -----------
  [clang][deps] Sanitize both instances of DiagnosticOptions

During dependency scanning, we generally want to suppress -Werror. Apply the same logic to the DiagnosticOptions instance used for command-line parsing.

This fixes a test failure on the PS4 bot, where the system header directory could not be found, which was reported due to -Werror being on the command line and not being sanitized.


  Commit: 7afabc2e4e8612f5221543039842c607ea96db90
      https://github.com/llvm/llvm-project/commit/7afabc2e4e8612f5221543039842c607ea96db90
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    A llvm/clang/test/ClangScanDeps/Inputs/diagnostics/cdb.json.template
    A llvm/clang/test/ClangScanDeps/Inputs/diagnostics/mod.h
    A llvm/clang/test/ClangScanDeps/Inputs/diagnostics/module.modulemap
    A llvm/clang/test/ClangScanDeps/Inputs/diagnostics/tu.c
    A llvm/clang/test/ClangScanDeps/diagnostics.c

  Log Message:
  -----------
  [clang][deps] Test diagnostic options are being respected

This patch tests code in D108976. This split is necessary to avoid temporary regression.

Depends on D108974,

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D109158


Compare: https://github.com/llvm/llvm-project/compare/ec7d8d5069bd...7afabc2e4e86