[all-commits] [llvm/llvm-project] c240d2: [lldb] [test] Move "platform connect" logic into a...

Fri Sep 10 05:08:50 PDT 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c240d2bb06dabe8fb3a1c2da978fbdc9f642de73
      https://github.com/llvm/llvm-project/commit/c240d2bb06dabe8fb3a1c2da978fbdc9f642de73
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteDiskFileCompletion.py
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
    M lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py

  Log Message:
  -----------
  [lldb] [test] Move "platform connect" logic into a common class

Create a common GDBPlatformClientTestBase class and move the platform
select/connect logic there to reduce duplication.

Differential Revision: https://reviews.llvm.org/D109585

  Commit: dbb0c14d2729d135d9d6bb2d0e858e128129da08
      https://github.com/llvm/llvm-project/commit/dbb0c14d2729d135d9d6bb2d0e858e128129da08
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/source/Commands/CommandObjectPlatform.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
    M lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py

  Log Message:
  -----------
  [lldb] Add new commands and tests for getting file perms & exists

Add two new commands 'platform get-file-permissions' and 'platform
file-exists' for the respective bits of LLDB protocol.  Add tests for
them.  Fix error handling in GetFilePermissions().

Differential Revision: https://reviews.llvm.org/D107809

  Commit: 501eaf88770d15de92fa0eb7435f0470a3b93b0a
      https://github.com/llvm/llvm-project/commit/501eaf88770d15de92fa0eb7435f0470a3b93b0a
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py

  Log Message:
  -----------
  [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

Add a GDB-compatible fallback to vFile:fstat for vFile:mode, and to
vFile:open for vFile:exists.  Note that this is only partial fallback,
as it fails if the file cannot be opened.

Differential Revision: https://reviews.llvm.org/D107811

  Commit: 6ba3f7237dc750aad2ce1d6a7a15e3b78370221a
      https://github.com/llvm/llvm-project/commit/6ba3f7237dc750aad2ce1d6a7a15e3b78370221a
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/include/lldb/Utility/StringExtractorGDBRemote.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
    M lldb/source/Utility/StringExtractorGDBRemote.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

  Log Message:
  -----------
  [lldb] [gdb-remote] Implement the vRun packet

Implement the simpler vRun packet and prefer it over the A packet.
Unlike the latter, it tranmits command-line arguments without redundant
indices and lengths.  This also improves GDB compatibility since modern
versions of gdbserver do not implement the A packet at all.

Make qLaunchSuccess not obligatory when using vRun.  It is not
implemented by gdbserver, and since vRun returns the stop reason,
we can assume it to be successful.

Differential Revision: https://reviews.llvm.org/D107931

  Commit: 3fade9542200c96021522f91ba5afdbff02729e1
      https://github.com/llvm/llvm-project/commit/3fade9542200c96021522f91ba5afdbff02729e1
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
    M lldb/test/API/tools/lldb-server/main.cpp

  Log Message:
  -----------
  [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

Fall back to QEnvironmentHexEncoded if QEnvironment is not supported.
The latter packet is an LLDB extension, while the former is universally
supported.

Add tests for both QEnvironment and QEnvironmentHexEncoded packets,
including both use due to characters that need escaping and fallback
when QEnvironment is not supported.

Differential Revision: https://reviews.llvm.org/D108018

  Commit: 3d3017d344f6514bbb2e5ff49a335d36e31faf55
      https://github.com/llvm/llvm-project/commit/3d3017d344f6514bbb2e5ff49a335d36e31faf55
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
    A lldb/source/Plugins/Process/gdb-remote/GDBRemoteErrno.def
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py

  Log Message:
  -----------
  [lldb] [gdb-remote] Use standardized GDB errno values

GDB uses normalized errno values for vFile errors.  Implement
the translation between them and system errno values in the gdb-remote
plugin.

Differential Revision: https://reviews.llvm.org/D108148

Compare: https://github.com/llvm/llvm-project/compare/fbe00c6874f1...3d3017d344f6