[all-commits] [llvm/llvm-project] b25ab4: [llvm-objcopy][COFF] Fix test for debug dir presence

alfonsosanchezbeato via All-commits all-commits at lists.llvm.org
Fri Sep 10 01:57:40 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b25ab4f313f38d3dee9674789cf56b9143515034
      https://github.com/llvm/llvm-project/commit/b25ab4f313f38d3dee9674789cf56b9143515034
  Author: Alfonso Sánchez-Beato <alfonso.sanchez-beato at canonical.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    A llvm/test/tools/llvm-objcopy/COFF/check-debug-dir-present.test
    M llvm/tools/llvm-objcopy/COFF/Writer.cpp

  Log Message:
  -----------
  [llvm-objcopy][COFF] Fix test for debug dir presence

If the number of directories was 6 (equal to the DEBUG_DIRECTORY
index), patchDebugDirectory() was run even though the debug directory
is actually the 7th entry. Use <= in the comparison to fix that.

This fixes https://llvm.org/PR51243

Differential Revision: https://reviews.llvm.org/D106940

Reviewed by: jhenderson




More information about the All-commits mailing list