[all-commits] [llvm/llvm-project] 2a5817: [openmp] No longer use LIBRARY_PATH to find devicertl

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Thu Sep 9 09:16:58 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a581710c1942b265b271e230368b1596132f242
      https://github.com/llvm/llvm-project/commit/2a581710c1942b265b271e230368b1596132f242
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-09-09 (Thu, 09 Sep 2021)

  Changed paths:
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    A clang/test/Driver/Inputs/libomptarget/libomptarget-new-nvptx-test.bc
    A clang/test/Driver/Inputs/libomptarget/subdir/libomptarget-nvptx-sm_35.bc
    M clang/test/Driver/amdgpu-openmp-toolchain.c
    M clang/test/Driver/openmp-offload-gpu.c
    M openmp/libomptarget/test/lit.cfg

  Log Message:
  -----------
  [openmp] No longer use LIBRARY_PATH to find devicertl

Given D109057, change test runner to use the libomptarget-x-bc-path
argument instead of the LIBRARY_PATH environment variable to find the device
library.

Also drop the use of LIBRARY_PATH environment variable as it is far
too easy to pull in the device library from an unrelated toolchain by accident
with the current setup. No loss in flexibility to developers as the clang
commandline used here is still available.

Reviewed By: jdoerfert, tianshilei1992

Differential Revision: https://reviews.llvm.org/D109061




More information about the All-commits mailing list