[all-commits] [llvm/llvm-project] a3870e: Reapply [runtimes] Set more paths when building ru...
Martin Storsjö via All-commits
all-commits at lists.llvm.org
Thu Sep 9 05:30:56 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: a3870e8ab164e796da4fe48c6abf899d79c09f6d
https://github.com/llvm/llvm-project/commit/a3870e8ab164e796da4fe48c6abf899d79c09f6d
Author: Martin Storsjö <martin at martin.st>
Date: 2021-09-09 (Thu, 09 Sep 2021)
Changed paths:
M libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake
M runtimes/CMakeLists.txt
Log Message:
-----------
Reapply [runtimes] Set more paths when building runtimes standalone
These paths are needed when building with per-target runtime directories.
(It's possible to fix this by manually setting these when invoking
cmake, but one isn't supposed to need to do that.)
Also set LLVM_TOOLS_BINARY_DIR while touching this area (as it's
also unset in this case) even if it isn't specifically needed by the
per-target runtime configuration.
Fixed since previous attempt: Don't check if the runtimes directory
is the root of the CMake invocation; when the main LLVM CMake
build builds runtimes, it does invoke a sub-CMake with this directory
as the root too, just as if manually invoking CMake at the runtimes
directory. Instead check whether LLVM_TOOLS_BINARY_DIR was set and
whether find_package(LLVM) succeeded or not.
Differential Revision: https://reviews.llvm.org/D107895
More information about the All-commits
mailing list