[all-commits] [llvm/llvm-project] 813235: [CMake] Don't add -Wnon-virtual-dtor if affected b...
Fangrui Song via All-commits
all-commits at lists.llvm.org
Tue Sep 7 23:36:59 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 813235947d07890ea55a6de039261d0c409c8b42
https://github.com/llvm/llvm-project/commit/813235947d07890ea55a6de039261d0c409c8b42
Author: Fangrui Song <i at maskray.me>
Date: 2021-09-07 (Tue, 07 Sep 2021)
Changed paths:
M llvm/cmake/modules/HandleLLVMOptions.cmake
Log Message:
-----------
[CMake] Don't add -Wnon-virtual-dtor if affected by GCC PR102168
See the discussion on
https://reviews.llvm.org/rG4852c770fe8703145dd2a35395985646ce57a454
The GCC behavior (https://gcc.gnu.org/PR102168) seems unhelpful.
Unconditional -Wnon-virtual-dtor led to other unnecessary workarounds like
6df09d6ccbc0cb72d3278cafb592e9bc0e6b84a1
This patches uses a variant of the 4bb5f44c701402462cb93ef00d46d52382f39f11
check to detect GCC PR102168.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D109404
More information about the All-commits
mailing list