[all-commits] [llvm/llvm-project] 217c6d: [libc++][NFC] Mark values in gdb pretty print comp...

Amy Kwan via All-commits all-commits at lists.llvm.org
Fri Sep 3 11:55:50 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 217c6d643124be312f4a99b203118744edb9d54c
      https://github.com/llvm/llvm-project/commit/217c6d643124be312f4a99b203118744edb9d54c
  Author: Amy Kwan <amy.kwan1 at ibm.com>
  Date:   2021-09-03 (Fri, 03 Sep 2021)

  Changed paths:
    M libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp

  Log Message:
  -----------
  [libc++][NFC] Mark values in gdb pretty print comparison functions as live to prevent values being optimized out.

It appears when testing LLVM 13 on Power, we run into failures with the
`libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp` test case optimizing
values out.

Despite some the functions in the test already being marked with optnone,
adding the `MarkAsLive()` calls inside of the pretty printer comparison functions
resolves the issues of the values being optimized out.

This patch aims to address https://llvm.org/PR51675.

Differential Revision: https://reviews.llvm.org/D109204




More information about the All-commits mailing list