[all-commits] [llvm/llvm-project] 5fb3f4: Fully qualify template template parameters when pr...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fb3f43778f85ebea48e880eef9493d188253890
      https://github.com/llvm/llvm-project/commit/5fb3f43778f85ebea48e880eef9493d188253890
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-09-02 (Thu, 02 Sep 2021)

  Changed paths:
    M clang-tools-extra/clangd/DumpAST.cpp
    M clang/include/clang/AST/TemplateName.h
    M clang/lib/AST/NestedNameSpecifier.cpp
    M clang/lib/AST/TemplateBase.cpp
    M clang/lib/AST/TemplateName.cpp
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/test/CXX/drs/dr10xx.cpp
    M clang/test/CXX/temp/temp.fct.spec/temp.deduct/temp.deduct.type/p9-0x.cpp
    M clang/test/Index/print-type.cpp
    M clang/test/Misc/diag-template.cpp
    M clang/test/SemaTemplate/temp_arg_template.cpp

  Log Message:
  -----------
  Fully qualify template template parameters when printing

I discovered this quirk when working on some DWARF - AST printing prints
type template parameters fully qualified, but printed template template
parameters the way they were written syntactically, or wholely
unqualified - instead, we should print them consistently with the way we
print type template parameters: fully qualified.

The one place this got weird was for partial specializations like in
ast-print-temp-class.cpp - hence the need for checking for
TemplateNameDependenceScope::DependentInstantiation template template
parameters. (not 100% sure that's the right solution to that, though -
open to ideas)

Differential Revision: https://reviews.llvm.org/D108794