[all-commits] [llvm/llvm-project] 3153bd: [libomptarget][amdgpu] Drop env variables

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Thu Sep 2 03:03:05 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3153bdd547c393b6b58e7cfaa5a40b246bf4218e
      https://github.com/llvm/llvm-project/commit/3153bdd547c393b6b58e7cfaa5a40b246bf4218e
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-09-02 (Thu, 02 Sep 2021)

  Changed paths:
    M openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
    M openmp/libomptarget/plugins/amdgpu/impl/data.cpp
    M openmp/libomptarget/plugins/amdgpu/impl/impl.cpp
    M openmp/libomptarget/plugins/amdgpu/impl/internal.h
    M openmp/libomptarget/plugins/amdgpu/impl/rt.h
    M openmp/libomptarget/plugins/amdgpu/impl/system.cpp
    R openmp/libomptarget/plugins/amdgpu/impl/utils.cpp
    M openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

  Log Message:
  -----------
  [libomptarget][amdgpu] Drop env variables

Use the same debug print as the rest of libomptarget plugins with
the same environment control. Also drop the max queue size debugging hook as
I don't believe it is still in use, can bring it back near the rest of the env
handling in rtl.cpp if someone objects.

That makes most of rt.h and all of utils.cpp unused. Clean that up and simplify
control flow in a couple of places.

Behaviour change is that debug prints that used to use the old environment
variable now use the new one and print in slightly different format, and the
removal of the max queue size variable.

Reviewed By: pdhaliwal

Differential Revision: https://reviews.llvm.org/D108784




More information about the All-commits mailing list