[all-commits] [llvm/llvm-project] a79d7c: [mlir][SPIRV] Add Image Operands for Image Instruc...

[Weiwei via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a79d7c2c85361276b61284475e5764ccd48e57dc
      https://github.com/llvm/llvm-project/commit/a79d7c2c85361276b61284475e5764ccd48e57dc
  Author: Weiwei Li <weiwei.li1 at huawei.com>
  Date:   2021-09-02 (Thu, 02 Sep 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVImageOps.td
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/test/Dialect/SPIRV/IR/image-ops.mlir

  Log Message:
  -----------
  [mlir][SPIRV] Add Image Operands for Image Instructions

This patch is to add Image Operands in SPIR-V Dialect and also let ImageDrefGather to use Image Operands.

Image Operands are used in many image instructions. "Image Operands encodes what oprands follow, as per Image Operands". And ususally, they are optional to image instructions.

The format of image operands looks like:

    %0 = spv.ImageXXXX %1, ... %3 : f32 ["Bias|Lod"](%4, %5 : f32, f32) -> ...

This patch doesn’t implement all operands (see Section 3.14 in SPIR-V Spec) but provides a skeleton of it. There is TODO in verifyImageOperands function.

Co-authored: Alan Liu <alanliu.yf at gmail.com>

Reviewed by: antiagainst

Differential Revision: https://reviews.llvm.org/D108501