[all-commits] [llvm/llvm-project] 718e5a: [libomptarget] Set runpath on libomptarget, use th...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Wed Sep 1 10:48:16 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 718e5a9883eb7f21638315db638d7a7615a3f247
      https://github.com/llvm/llvm-project/commit/718e5a9883eb7f21638315db638d7a7615a3f247
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-09-01 (Wed, 01 Sep 2021)

  Changed paths:
    M openmp/libomptarget/src/CMakeLists.txt
    M openmp/libomptarget/test/lit.cfg

  Log Message:
  -----------
  [libomptarget] Set runpath on libomptarget, use that to drop LD_LIBRARY_PATH from test runner

Using rpath instead of LD_LIBRARY_PATH to find libomp.so and
libomptarget.so lets one rerun the already built test executables without
setting environment variables and removes the risk of the test runner picking
up different libraries to the developer debugging the failure.

rpath usually means runpath, which is not transitive, so set runpath on
libomptarget itself so that it can find the plugins located next to it,
spelled $ORIGIN. This provides sufficient functionality to drop D102043

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D109071




More information about the All-commits mailing list