[all-commits] [llvm/llvm-project] 4852c7: [SCEV] Fix GCC -Wnon-virtual-dtor

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Sep 1 01:12:45 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4852c770fe8703145dd2a35395985646ce57a454
      https://github.com/llvm/llvm-project/commit/4852c770fe8703145dd2a35395985646ce57a454
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-09-01 (Wed, 01 Sep 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/ScalarEvolution.h

  Log Message:
  -----------
  [SCEV] Fix GCC -Wnon-virtual-dtor

SCEVPredicate has a friend declaration. The friend can technically call the
protected destructor, so the warning is legitimate. Clang simply doesn't implement
the friend check.

Make the dtor virtual to fix the issue.




More information about the All-commits mailing list