[all-commits] [llvm/llvm-project] e983a6: [libc++][NFC] split <charconv>.

mordante via All-commits all-commits at lists.llvm.org
Tue Aug 31 09:45:31 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e983a659e51c0ed2a7e0da770be6b3b4f2efcd05
      https://github.com/llvm/llvm-project/commit/e983a659e51c0ed2a7e0da770be6b3b4f2efcd05
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2021-08-31 (Tue, 31 Aug 2021)

  Changed paths:
    M libcxx/include/CMakeLists.txt
    A libcxx/include/__charconv/chars_format.h
    A libcxx/include/__charconv/from_chars_result.h
    A libcxx/include/__charconv/to_chars_result.h
    M libcxx/include/charconv
    M libcxx/include/module.modulemap
    A libcxx/test/libcxx/diagnostics/detail.headers/charconv/chars_format.module.verify.cpp
    A libcxx/test/libcxx/diagnostics/detail.headers/charconv/from_chars_result.module.verify.cpp
    A libcxx/test/libcxx/diagnostics/detail.headers/charconv/to_chars_result.module.verify.cpp

  Log Message:
  -----------
  [libc++][NFC] split <charconv>.

This move the helper types `chars_format`, `to_chars_result` and
`from_chars_result` to a separate header. The first two are needed for
D70631 the third for consistency.

The header `__charconv/ryu.h` uses these types and it can't depend on the
types in `<charconv>` in a modular build. Moving them to the ryu header
would be an odd place and doesn't work since the header is included in the
middle of `<charconv>`.

Reviewed By: #libc, ldionne, Quuxplusone

Differential Revision: https://reviews.llvm.org/D108927




More information about the All-commits mailing list