[all-commits] [llvm/llvm-project] 71d7fe: [OptTable] Improve error message output for groupe...

[gbreynoo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 71d7fed3bc2ad6c22729d446526a59fcfd99bd03
      https://github.com/llvm/llvm-project/commit/71d7fed3bc2ad6c22729d446526a59fcfd99bd03
  Author: gbreynoo <Owen.Reynolds at sony.com>
  Date:   2021-08-31 (Tue, 31 Aug 2021)

  Changed paths:
    M llvm/lib/Option/OptTable.cpp
    M llvm/test/tools/llvm-objcopy/tool-help-message.test
    M llvm/unittests/Option/OptionParsingTest.cpp

  Log Message:
  -----------
  [OptTable] Improve error message output for grouped short options

As seen in https://bugs.llvm.org/show_bug.cgi?id=48880 the current
implementation for parsing grouped short options can return unclear
error messages. This change fixes the example given in the ticket in
which a flag is incorrectly given an argument. Also when parsing a
group we now keep reading past the first incorrect option and output
errors for all incorrect options in the group.

Differential Revision: https://reviews.llvm.org/D108770