[all-commits] [llvm/llvm-project] 4cacb5: [MergeICmps] Don't merge icmps derived from pointe...

Valentin Churavy via All-commits all-commits at lists.llvm.org
Fri Aug 27 13:15:26 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4cacb5cad052b14d37703157f3b7ffc6a6610acc
      https://github.com/llvm/llvm-project/commit/4cacb5cad052b14d37703157f3b7ffc6a6610acc
  Author: Valentin Churavy <v.churavy at gmail.com>
  Date:   2021-08-27 (Fri, 27 Aug 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/MergeICmps.cpp
    A llvm/test/Transforms/MergeICmps/X86/addressspaces.ll

  Log Message:
  -----------
  [MergeICmps] Don't merge icmps derived from pointers with addressspaces

IIUC we can't emit `memcmp` between pointers in addressspaces,
doing so will trigger an assertion since the signature of the memcmp
will not match it's arguments (https://bugs.llvm.org/show_bug.cgi?id=48661).

This PR disables the attempt to merge icmps,
when the pointer is in an addressspace.

Reviewed By: #julialang, vtjnash

Differential Revision: https://reviews.llvm.org/D94813




More information about the All-commits mailing list