[all-commits] [llvm/llvm-project] 198edf: [libc++] XFAIL align.pass.cpp for PowerPC LE

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Aug 26 10:23:20 PDT 2021


  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 198edf09f58e19ae912206f871207af3ceace192
      https://github.com/llvm/llvm-project/commit/198edf09f58e19ae912206f871207af3ceace192
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-08-26 (Thu, 26 Aug 2021)

  Changed paths:
    M libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp

  Log Message:
  -----------
  [libc++] XFAIL align.pass.cpp for PowerPC LE

This patch XFAILs the `align.pass.cpp` for PowerPC (LE).

It appears that this test will fail on Power for the `LLIArr2` and `Padding` structs within the test,
as the `assert` for `alignof(AtomicImpl) >= sizeof(AtomicImpl)` will be false. In this case, these structs
presumably should not be lock-free, so we currently XFAIL this for now.

The failure was discovered after D97913 was committed. It looks like `alignof(AtomicImpl) < sizeof(AtomicImpl)`,
even prior to this commit, but this test began running on Power after D97913, whereas we were
not running `align.pass.cpp` before.

This patch addresses https://bugs.llvm.org/show_bug.cgi?id=51548 by temporarily XFAILing the test
in order to investigate it further.

Differential Revision: https://reviews.llvm.org/D108668

(cherry picked from commit f640c31e4b12e6d12d2fc540451e07bf49dba257)




More information about the All-commits mailing list