[all-commits] [llvm/llvm-project] bf66b0: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6b...

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf66b0eefcda20170eeb574670121159fcd755fa
      https://github.com/llvm/llvm-project/commit/bf66b0eefcda20170eeb574670121159fcd755fa
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2021-08-26 (Thu, 26 Aug 2021)

  Changed paths:
    M clang/include/clang/Basic/Stack.h

  Log Message:
  -----------
  Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

We should be using #if instead of #ifdef here since LLVM_ENABLE_THREADS
is set using #cmakedefine01 so is always defined.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D108110


  Commit: 7cab90a7b1c47780bbf7cfbfda4a1cbab24f0e5b
      https://github.com/llvm/llvm-project/commit/7cab90a7b1c47780bbf7cfbfda4a1cbab24f0e5b
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2021-08-26 (Thu, 26 Aug 2021)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/CodeGen/CodeGenTypeCache.h
    M clang/test/CodeGen/annotations-global.c

  Log Message:
  -----------
  Fix __attribute__((annotate("")) with non-zero globals AS

The existing code attempting to bitcast from a value in the default globals AS
to i8 addrspace(0)* was triggering an assertion failure in our downstream fork.
I found this while compiling poppler for CHERI-RISC-V (we use AS200 for all
globals). The test case uses AMDGPU since that is one of the in-tree targets
with a non-zero default globals address space.
The new test previously triggered a "Invalid constantexpr bitcast!" assertion
and now correctly generates code with addrspace(1) pointers.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D105972


  Commit: 581613413c273012747676d9b0f0970cc26d5683
      https://github.com/llvm/llvm-project/commit/581613413c273012747676d9b0f0970cc26d5683
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2021-08-26 (Thu, 26 Aug 2021)

  Changed paths:
    M llvm/include/llvm/IR/Value.h

  Log Message:
  -----------
  Make Value::MaxAlignment(Exponent) constexpr

This avoids references to the variables be generated when using e.g. max().

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D95050


Compare: https://github.com/llvm/llvm-project/compare/aa5b6c97793a...581613413c27