[all-commits] [llvm/llvm-project] 400a1d: [lld/COFF] Improve handling of the /manifestdepend...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 400a1de3ac4583794797852aab49aaa821c95b7d
      https://github.com/llvm/llvm-project/commit/400a1de3ac4583794797852aab49aaa821c95b7d
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-08-25 (Wed, 25 Aug 2021)

  Changed paths:
    M lld/COFF/Config.h
    M lld/COFF/Driver.cpp
    M lld/COFF/DriverUtils.cpp
    A lld/test/COFF/Inputs/manifestdependency-drectve.yaml
    M lld/test/COFF/linkrepro-manifest.test
    M lld/test/COFF/manifest.test

  Log Message:
  -----------
  [lld/COFF] Improve handling of the /manifestdependency: flag

If multiple /manifestdependency: flags are passed, they are
naively deduped, but after that each of them should have an
effect, instead of just the last one.

Also, /manifestdependency: flags are allowed in .drectve sections
(from `#pragma comment(linker, ...`). To make the interaction between
/manifestdependency: flags enabling manifest by default but
/manifest:no overriding this work, add an explict ManifestKind::Default
state to represent no explicit /manifest flag being passed.
To make /manifestdependency: flags from input file .drectve sections
work with /manifest:embed, delay embedded manifest emission until
after input files have been read.

Differential Revision: https://reviews.llvm.org/D108628