[all-commits] [llvm/llvm-project] 32e232: Revert D108432 "[InstrProfiling] Keep profd non-pr...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 32e2326cda441528f75404b1c93374722caaf21c
      https://github.com/llvm/llvm-project/commit/32e2326cda441528f75404b1c93374722caaf21c
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
    M llvm/test/Instrumentation/InstrProfiling/linkage.ll
    M llvm/test/Transforms/PGOProfile/comdat.ll

  Log Message:
  -----------
  Revert D108432 "[InstrProfiling] Keep profd non-private for non-renamable comdat functions"

This reverts commit f653beea88d2684cdc8117e662b321ba04666771.

It broke Windows coverage-inline.cpp because link.exe has a limitation
that external symbols in IMAGE_COMDAT_SELECT_ASSOCIATIVE don't work.

It essentially dropped the previous size optimization for coverage
because coverage doesn't rename comdat by default.
Needs more investigation what we should do.