[all-commits] [llvm/llvm-project] 90e0c6: [mlir][sparse] Correcting the use of emplace_back

wren romano via All-commits all-commits at lists.llvm.org
Tue Aug 24 18:32:31 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 90e0c657b7cb3e4dd87229e338061d3cc27f6977
      https://github.com/llvm/llvm-project/commit/90e0c657b7cb3e4dd87229e338061d3cc27f6977
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M mlir/lib/ExecutionEngine/SparseUtils.cpp

  Log Message:
  -----------
  [mlir][sparse] Correcting the use of emplace_back

The emplace commands are variadic and should take all the constructor arguments directly, since they implicitly call the constructor themselves in order to avoid the cost of constructing and then moving/copying temporaries.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D108670




More information about the All-commits mailing list