[all-commits] [llvm/llvm-project] 1c53ca: [orc] Fix unit tests that use ORC C API

Ben Langmuir via All-commits all-commits at lists.llvm.org
Tue Aug 24 14:20:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c53cadf08c07fb3fa70993c6210355c58c3b149
      https://github.com/llvm/llvm-project/commit/1c53cadf08c07fb3fa70993c6210355c58c3b149
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M compiler-rt/lib/orc/c_api.h
    M compiler-rt/lib/orc/unittests/c_api_test.cpp

  Log Message:
  -----------
  [orc] Fix unit tests that use ORC C API

* c_api_tests was failing to build after the API change to
  __orc_rt_CWrapperFunctionResultAllocate

* wrapper_function_utils_test was causing an assertion failure, because
  it was creating a result for `void(void)` with Size = 0, but seeing an
  uninitialized pointer, which it considered to be an out-of-bound
  error.

I noticed locally that making modifications to c_api.h is not causing
these unit tests to be rebuilt, which may be how the bug slipped in in
the first place.

Differential Revision: https://reviews.llvm.org/D108649




More information about the All-commits mailing list