[all-commits] [llvm/llvm-project] 3265b9: [flang] Extension: reduced scope for some implied ...

[Peter Klausler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3265b93363d8540ee96357bfd708cc36b8c89280
      https://github.com/llvm/llvm-project/commit/3265b93363d8540ee96357bfd708cc36b8c89280
  Author: peter klausler <pklausler at nvidia.com>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M flang/docs/Extensions.md
    M flang/lib/Semantics/expression.cpp
    M flang/lib/Semantics/resolve-names.cpp
    M flang/test/Semantics/array-constr-values.f90
    A flang/test/Semantics/data11.f90
    M flang/test/Semantics/modfile25.f90
    M flang/test/Semantics/modfile26.f90
    A flang/test/Semantics/resolve106.f90
    M flang/test/Semantics/resolve30.f90
    M flang/test/Semantics/symbol05.f90

  Log Message:
  -----------
  [flang] Extension: reduced scope for some implied DO loop indices

The index of an implied DO loop in a DATA statement or array
constructor is defined by Fortran 2018 to have scope over its
implied DO loop.  This definition is unfortunate, because it
requires the implied DO loop's bounds expressions to be in the
scope of the index variable.  Consequently, in code like

  integer, parameter :: j = 5
  real, save :: a(5) = [(j, j=1, j)]

the upper bound of the loop is a reference to the index variable,
not the parameter in the enclosing scope.

This patch limits the scope of the index variable to the "body"
of the implied DO loop as one would naturally expect, with a warning.
I would have preferred to make this a hard error, but most Fortran
compilers treat this case as f18 now does.  If the standard
were to be fixed, the warning could be made optional.

Differential Revision: https://reviews.llvm.org/D108595