[all-commits] [llvm/llvm-project] 039b46: [ARM] Allow using '; ' as asm statement separator i...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue Aug 24 01:02:26 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 039b469b85814ba14bee224785f19527cc25ecf1
      https://github.com/llvm/llvm-project/commit/039b469b85814ba14bee224785f19527cc25ecf1
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
    M llvm/test/CodeGen/ARM/cfguard-checks.ll
    M llvm/test/MC/ARM/Windows/literals-comments.s

  Log Message:
  -----------
  [ARM] Allow using ';' as asm statement separator in MSVC mode

This does the same as D96259, but for ARM, just like AArch64,
using the same comment char as for ELF and MinGW mode.

As the assembly input/output of LLVM is GAS style, trying to
match what MS armasm.exe does isn't needed (because the comment
char used is the least concern when it comes to that; all
directives differ too). If a separate armasm compatible mode
is implemented, it can use its own comment style (just like
llvm-ml implements MS ml.exe compatible assembly parsing).

This fixes building compiler-rt assembly files for ARM in MSVC
mode.

The updated testcase literals-comments.s was only intended to
make sure that '#' isn't interpreted as a comment char.

Differential Revision: https://reviews.llvm.org/D107251




More information about the All-commits mailing list