[all-commits] [llvm/llvm-project] c2574e: [openmp][nfc] Refactor GridValues

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Mon Aug 23 08:20:53 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c2574e63ff71c1d3caea48cb6200c2422bd8f33d
      https://github.com/llvm/llvm-project/commit/c2574e63ff71c1d3caea48cb6200c2422bd8f33d
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-08-23 (Mon, 23 Aug 2021)

  Changed paths:
    M clang/include/clang/Basic/TargetInfo.h
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/AMDGPU.h
    M clang/lib/Basic/Targets/NVPTX.cpp
    M clang/lib/Basic/Targets/NVPTX.h
    M clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
    M llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h

  Log Message:
  -----------
  [openmp][nfc] Refactor GridValues

Remove redundant fields and replace pointer with virtual function

Of fourteen fields, three are dead and four can be computed from the
remainder. This leaves a couple of currently dead fields in place as
they are expected to be used from the deviceRTL shortly. Two of the
fields that can be computed are only used from codegen and require a
log2() implementation so are inlined into codegen instead.

This change leaves the new methods in the same location in the struct
as the previous fields for convenience at review.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D108380




More information about the All-commits mailing list