[all-commits] [llvm/llvm-project] fbb8e7: [InstrProfiling] Make COFF use the ELF comdat sche...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Aug 19 16:38:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fbb8e772ec501a1b71643db90e9c6445e17d7cac
      https://github.com/llvm/llvm-project/commit/fbb8e772ec501a1b71643db90e9c6445e17d7cac
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-08-19 (Thu, 19 Aug 2021)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
    M llvm/test/Instrumentation/InstrProfiling/linkage.ll
    M llvm/test/Instrumentation/InstrProfiling/platform.ll
    M llvm/test/Instrumentation/InstrProfiling/profiling.ll

  Log Message:
  -----------
  [InstrProfiling] Make COFF use the ELF comdat scheme (drop link.exe compatibility)

The COFF specific `DataReferencedByCode` complexity (D103372 D103717) is due to
a link.exe limitation: an external symbol in IMAGE_COMDAT_SELECT_ASSOCIATIVE is
not really dropped, so it can cause duplicate definition error.




More information about the All-commits mailing list