[all-commits] [llvm/llvm-project] 475f83: [libc++][NFCI] Remove unnecessary exception-throwi...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 475f831b178c917206cc89925c3ee63b2aec088d
      https://github.com/llvm/llvm-project/commit/475f831b178c917206cc89925c3ee63b2aec088d
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-08-19 (Thu, 19 Aug 2021)

  Changed paths:
    M libcxx/include/__split_buffer
    M libcxx/include/deque

  Log Message:
  -----------
  [libc++][NFCI] Remove unnecessary exception-throwing base classes

__split_buffer_common was entirely unused, and __deque_base_common
was unused except for two calls to __throw_out_of_range(), which have
been inlined.

The usual intent of the __xxx_base_common base classes is to localize
where the exception-throwing code is instantiated, however that wasn't
the case here because we never explicitly instantiated those base classes
in the shared library, unlike what we do for basic_string and vector.

Differential Revision: https://reviews.llvm.org/D108384