[all-commits] [llvm/llvm-project] 0541ce: [CRT][LIT] build the target_cflags for Popen properly

jsji via All-commits all-commits at lists.llvm.org
Thu Aug 19 08:40:43 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0541ce4ef9cae2176dc80d32fd5225208f2059e3
      https://github.com/llvm/llvm-project/commit/0541ce4ef9cae2176dc80d32fd5225208f2059e3
  Author: Jinsong Ji <jji at us.ibm.com>
  Date:   2021-08-19 (Thu, 19 Aug 2021)

  Changed paths:
    M compiler-rt/test/crt/lit.cfg.py

  Log Message:
  -----------
  [CRT][LIT] build the target_cflags for Popen properly

We recently enabled crt for powerpc in
https://reviews.llvm.org/rGb7611ad0b16769d3bf172e84fa9296158f8f1910.

And we started to see some unexpected error message when running
check-runtimes.

eg:
https://lab.llvm.org/buildbot/#/builders/57/builds/9488/steps/6/logs/stdio
line 100 - 103:

"
clang-14: error: unknown argument: '-m64 -fno-function-sections'
clang-14: error: unknown argument: '-m64 -fno-function-sections'
clang-14: error: unknown argument: '-m64 -fno-function-sections'
clang-14: error: unknown argument: '-m64 -fno-function-sections'
"

Looks like we shouldn't strip the space at the beginning,
or else the command line passed to subprocess won't work well.

Reviewed By: phosek, MaskRay

Differential Revision: https://reviews.llvm.org/D108329




More information about the All-commits mailing list