[all-commits] [llvm/llvm-project] dcc6b7: [OptTable] Refine how `printHelp` treats empty hel...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b
      https://github.com/llvm/llvm-project/commit/dcc6b7b1d5e5a0f9537ce1bf919ac2338bd7ad7b
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2021-08-19 (Thu, 19 Aug 2021)

  Changed paths:
    M flang/test/Driver/driver-help-hidden.f90
    M flang/test/Driver/driver-help.f90
    M llvm/lib/Option/OptTable.cpp
    M llvm/test/tools/llvm-cvtres/help.test
    M llvm/tools/llvm-cvtres/Opts.td

  Log Message:
  -----------
  [OptTable] Refine how `printHelp` treats empty help texts

Currently, `printHelp` behaves differently for options that:
  * do not define `HelpText` (such options _are not printed_), and
  * define its `HelpText` as `HelpText<"">` (such options _are printed_).
In practice, both approaches lead to no help text and `printHelp` should
treat them consistently. This patch addresses that by making
`printHelpt` check the length of the help text to be printed.

All affected tests have been updated accordingly. The option definitions
for llvm-cvtres have been updated with a short description or "Not
  implemented" for options that are ignored by the tool.

Differential Revision: https://reviews.llvm.org/D107557