[all-commits] [llvm/llvm-project] edb8ac: [Libomptarget] Correctly default to Generic if exe...

Joseph Huber via All-commits all-commits at lists.llvm.org
Wed Aug 18 08:24:55 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: edb8acdc6ea291308ee3b1b0e697adba183ccd5e
      https://github.com/llvm/llvm-project/commit/edb8acdc6ea291308ee3b1b0e697adba183ccd5e
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2021-08-18 (Wed, 18 Aug 2021)

  Changed paths:
    M openmp/libomptarget/plugins/cuda/src/rtl.cpp
    A openmp/libomptarget/test/offloading/global_constructor.cpp

  Log Message:
  -----------
  [Libomptarget] Correctly default to Generic if exec_mode is not present

Currently, the runtime returns an error when the `exec_mode` global is
not present. The expected behvaiour is that the region will default to
Generic. This prevents global constructors from being called because
they do not contain execution mode globals.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D108255


  Commit: 58f93264878a3fb9db9d901c5d7dfdcde4291d6a
      https://github.com/llvm/llvm-project/commit/58f93264878a3fb9db9d901c5d7dfdcde4291d6a
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2021-08-18 (Wed, 18 Aug 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/OpenMPOpt.cpp
    A llvm/test/Transforms/OpenMP/global_constructor.ll

  Log Message:
  -----------
  [OpenMP] Change AAKernelInfo to ignore non-kernels

Currently, AAKernelInfo will fail on an assertion if we attempt to run
it on a kernel without the init / deinit runtime calls. However, this
occurs for global constructors on the device. This will cause OpenMPOpt
to crash whenever global constructors are present. This patch removes
this assertion and just gives up instead.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D108258


Compare: https://github.com/llvm/llvm-project/compare/1ffbe8c04ff2...58f93264878a


More information about the All-commits mailing list