[all-commits] [llvm/llvm-project] 8c2ff7: [MLIR] Correct linkage of lowered globalop

[William Moses via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c2ff7b69e77a9eccf4a13bcc21dee5894b251af
      https://github.com/llvm/llvm-project/commit/8c2ff7b69e77a9eccf4a13bcc21dee5894b251af
  Author: William S. Moses <gh at wsmoses.com>
  Date:   2021-08-18 (Wed, 18 Aug 2021)

  Changed paths:
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir

  Log Message:
  -----------
  [MLIR] Correct linkage of lowered globalop

LLVM considers global variables marked as externals to be defined within the module if it is initialized (including to an undef). Other external globals are considered as being defined externally and imported into the current translation unit. Lowering of MLIR Global Ops does not properly propagate undefined initializers, resulting in a global which is expected to be defined within the current TU, not being defined.

Differential Revision: https://reviews.llvm.org/D108252