[all-commits] [llvm/llvm-project] 79e950: [LLDB][GUI] Refactor form drawing using subsurfaces

Omar Emara via All-commits all-commits at lists.llvm.org
Tue Aug 17 16:54:56 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 79e950a29e004f2f0ac590f6090b61b3043503e2
      https://github.com/llvm/llvm-project/commit/79e950a29e004f2f0ac590f6090b61b3043503e2
  Author: Omar Emara <mail at OmarEmara.dev>
  Date:   2021-08-17 (Tue, 17 Aug 2021)

  Changed paths:
    M lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [LLDB][GUI] Refactor form drawing using subsurfaces

This patch adds a new method SubSurface to the Surface class. The method
returns another surface that is a subset of this surface. This is
important to further abstract away drawing from the ncurses objects. For
instance, fields could previously be drawn on subpads only but can now
be drawn on any surface. This is needed to create the file search
dialogs and similar functionalities.

There is an opportunity to refactor window drawing in general using
surfaces, but we shall consider this separately later.

Differential Revision: https://reviews.llvm.org/D107761




More information about the All-commits mailing list