[all-commits] [llvm/llvm-project] 2af4db: Migrate DWARFVerifier tests to lit-based yaml inst...

David Blaikie via All-commits all-commits at lists.llvm.org
Fri Aug 13 19:35:32 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2af4db7d5cc8e752634a249cf328b27836810245
      https://github.com/llvm/llvm-project/commit/2af4db7d5cc8e752634a249cf328b27836810245
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-08-13 (Fri, 13 Aug 2021)

  Changed paths:
    A llvm/test/tools/llvm-dwarfdump/X86/verify_cu_dont_share_line_table.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_curanges_incomplete.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_duplicate_file_warning.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_elided_doesnt_fail.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_cu_ref.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_die_range.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_line_file_index.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_line_sequence.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_line_table_prologue_dir_index.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_ranges.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_ref_addr.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_ref_addr_between.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_rnglists.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_stmt_list.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_strp.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_lexical_block_ranges.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_nested_functions.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_function_ranges.yaml
    A llvm/test/tools/llvm-dwarfdump/X86/verify_overlapping_lexical_block_ranges.yaml
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

  Log Message:
  -----------
  Migrate DWARFVerifier tests to lit-based yaml instead of gtest with embedded yaml

Improves maintainability (edit/modify the tests without recompiling) and
error messages (previously the failure would be a gtest failure
mentioning nothing of the input or desired text) and the option to
improve tests with more checks.

(maybe these tests shouldn't all be in separate files - we could
probably have DWARF yaml that contains multiple errors while still being
fairly maintainable - the various invalid offsets (ref_addr, rnglists,
ranges, etc) could probably be all in one test, but for the simple sake
of the migration I just did the mechanical thing here)




More information about the All-commits mailing list