[all-commits] [llvm/llvm-project] c19d7f: [CallPromotion] Check for inalloca/byval mismatch

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c19d7f8af0321d1b90343496ebd1c1aec3f1dc8c
      https://github.com/llvm/llvm-project/commit/c19d7f8af0321d1b90343496ebd1c1aec3f1dc8c
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-08-13 (Fri, 13 Aug 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
    A llvm/test/Transforms/PGOProfile/mismatched-byval.ll
    A llvm/test/Transforms/PGOProfile/mismatched-inalloca.ll

  Log Message:
  -----------
  [CallPromotion] Check for inalloca/byval mismatch

Previously we would allow promotion even if the byval/inalloca
attributes on the call and the callee didn't match.

It's ok if the byval/inalloca types aren't the same. For example, LTO
importing may rename types.

Fixes PR51397.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D107998