[all-commits] [llvm/llvm-project] 64f29e: Fix bad assert in print-changed code

jamieschmeiser via All-commits all-commits at lists.llvm.org
Fri Aug 13 07:54:49 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64f29e2dd12905b2d71e6f4b3d390c3df4cb0a80
      https://github.com/llvm/llvm-project/commit/64f29e2dd12905b2d71e6f4b3d390c3df4cb0a80
  Author: Jamie Schmeiser <schmeise at ca.ibm.com>
  Date:   2021-08-13 (Fri, 13 Aug 2021)

  Changed paths:
    M llvm/lib/Passes/StandardInstrumentations.cpp
    A llvm/test/Other/ChangePrinters/print-changed-D107989.ll

  Log Message:
  -----------
  Fix bad assert in print-changed code

Summary:
The assertion that both functions were not missing was incorrect and would
fail when one of the functions was missing. Fixed it and moved the
assertion earlier to check the input parameters to better capture
first-failure.  Added lit test.

Author: Jamie Schmeiser <schmeise at ca.ibm.com>
Reviewed By: aeubanks (Arthur Eubanks)
Differential Revision: https://reviews.llvm.org/D107989




More information about the All-commits mailing list