[all-commits] [llvm/llvm-project] 3f9643: [lldb] Skip TestConcurrent.* watchpoint tests for ...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Aug 11 14:42:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f96438c201e933809fabc39368686884b98f057
      https://github.com/llvm/llvm-project/commit/3f96438c201e933809fabc39368686884b98f057
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-08-11 (Wed, 11 Aug 2021)

  Changed paths:
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentDelayWatchBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentNWatchNBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalNWatchNBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalWatch.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalWatchBreak.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointThreads.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneBreakpoint.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneDelayBreakpoint.py
    M lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py

  Log Message:
  -----------
  [lldb] Skip TestConcurrent.* watchpoint tests for Darwin on ARM

All TestConcurrent.* tests that involve watchpoints are broken on
ARM-based Darwin platforms, including Apple Silicon.

rdar://81811539


  Commit: 9f4b130defc17cbb107ca2186ef6b0f0ff649fd3
      https://github.com/llvm/llvm-project/commit/9f4b130defc17cbb107ca2186ef6b0f0ff649fd3
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-08-11 (Wed, 11 Aug 2021)

  Changed paths:
    M lldb/test/API/macosx/skinny-corefile/TestSkinnyCorefile.py

  Log Message:
  -----------
  [lldb] Replace assertTrue(foo in bar) with assertIn(foo, bar)

The benefit of using assertIn is an improved error message when the
assertion fails:

  AssertionError: False is not True

becomes

  AssertionError: 'have ints 5 20 20 5' not found in '""'


Compare: https://github.com/llvm/llvm-project/compare/b97afc9dc0e9...9f4b130defc1


More information about the All-commits mailing list