[all-commits] [llvm/llvm-project] 679707: libcang: Add missing function to libclang.map

Tom Stellard via All-commits all-commits at lists.llvm.org
Tue Aug 10 19:03:47 PDT 2021


  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 67970771d91c3f77fe3e2e1f8989afd7e9cdab3c
      https://github.com/llvm/llvm-project/commit/67970771d91c3f77fe3e2e1f8989afd7e9cdab3c
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M clang/tools/libclang/libclang.map

  Log Message:
  -----------
  libcang: Add missing function to libclang.map

This function is marked with CINDEX_LINKAGE, but was never added to the
export list / linker script.

Reviewed By: jrtc27

Differential Revision: https://reviews.llvm.org/D106974

(cherry picked from commit a4edb2b1ba0bda9042e87ca3f3e1b9f70598df9a)


  Commit: b33de5411594508c2ef357d5db10b8705e9b302a
      https://github.com/llvm/llvm-project/commit/b33de5411594508c2ef357d5db10b8705e9b302a
  Author: Rainer Orth <ro at gcc.gnu.org>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M clang/tools/libclang/CMakeLists.txt
    M clang/tools/libclang/libclang.map

  Log Message:
  -----------
  [clang] Fix libclang linking on Solaris

Linking `libclang.so` is currently broken on Solaris:

  ld: fatal: option --version-script requires option -z gnu-version-script-compat to be specified

While Solaris `ld` supports a considerable subset of `--version-script`,
there are some elements of the syntax that aren't.

The fix is equivalent to D78510 <https://reviews.llvm.org/D78510>.

Additionally, use of C-style comments is a GNU extension
that can easily be avoided by using `#` as comment character, which is
supported by GNU `ld`, `gold`, and `lld`.

Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`,
`x86_64-pc-linux-gnu`.

Differential Revision: https://reviews.llvm.org/D107559

(cherry picked from commit a382a746275b4a1eb1867331efa2319c614305d8)


Compare: https://github.com/llvm/llvm-project/compare/4dd681568552...b33de5411594


More information about the All-commits mailing list