[all-commits] [llvm/llvm-project] 76093b: [InlineAdvisor] Add single quotes around caller/ca...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 76093b17394af6f1bbe12d1fcf14ecbeb0a869df
      https://github.com/llvm/llvm-project/commit/76093b17394af6f1bbe12d1fcf14ecbeb0a869df
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M clang/test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
    M clang/test/Frontend/optimization-remark-line-directive.c
    M clang/test/Frontend/optimization-remark-new-pm.c
    M clang/test/Frontend/optimization-remark-with-hotness-new-pm.c
    M clang/test/Frontend/optimization-remark-with-hotness.c
    M clang/test/Frontend/optimization-remark.c
    M clang/test/Frontend/remarks-hotness.cpp
    M lld/test/ELF/lto/opt-remarks.ll
    M llvm/lib/Analysis/InlineAdvisor.cpp
    M llvm/lib/Analysis/ReplayInlineAdvisor.cpp
    M llvm/test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll
    M llvm/test/LTO/Resolution/X86/diagnostic-handler-remarks.ll
    M llvm/test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll
    M llvm/test/LTO/X86/diagnostic-handler-remarks.ll
    M llvm/test/Other/optimization-remarks-auto.ll
    M llvm/test/Other/optimization-remarks-inline.ll
    M llvm/test/ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll
    M llvm/test/ThinLTO/X86/diagnostic-handler-remarks.ll
    M llvm/test/Transforms/Inline/ARM/inline-fp.ll
    M llvm/test/Transforms/Inline/Inputs/cgscc-inline-replay.txt
    M llvm/test/Transforms/Inline/cgscc-inline-replay.ll
    M llvm/test/Transforms/Inline/inline_noprofile.ll
    M llvm/test/Transforms/Inline/inline_nossp.ll
    M llvm/test/Transforms/Inline/optimization-remarks-hotness-threshold.ll
    M llvm/test/Transforms/Inline/optimization-remarks-passed-yaml.ll
    M llvm/test/Transforms/Inline/optimization-remarks-with-hotness.ll
    M llvm/test/Transforms/Inline/optimization-remarks.ll
    M llvm/test/Transforms/SampleProfile/Inputs/inline-replay.txt
    M llvm/test/Transforms/SampleProfile/csspgo-inline-icall.ll
    M llvm/test/Transforms/SampleProfile/csspgo-inline.ll
    M llvm/test/Transforms/SampleProfile/inline-replay.ll
    M llvm/test/Transforms/SampleProfile/pseudo-probe-inline.ll
    M llvm/test/Transforms/SampleProfile/remarks-hotness.ll
    M llvm/test/Transforms/SampleProfile/remarks.ll
    M llvm/test/tools/gold/X86/opt-remarks.ll
    M llvm/test/tools/gold/X86/remarks.ll

  Log Message:
  -----------
  [InlineAdvisor] Add single quotes around caller/callee names

Clang diagnostics refer to identifier names in quotes.
This patch makes inline remarks conform to the convention.
New behavior:

```
% clang -O2 -Rpass=inline -Rpass-missed=inline -S a.c
a.c:4:25: remark: 'foo' inlined into 'bar' with (cost=-30, threshold=337) at callsite bar:0:25; [-Rpass=inline]
int bar(int a) { return foo(a); }
                        ^
```

Reviewed By: hoy

Differential Revision: https://reviews.llvm.org/D107791