[all-commits] [llvm/llvm-project] 5d106f: tsan: remove indirection when selecting the active...

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Tue Aug 10 11:07:44 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d106f16b972884fb81c7dac338eeeb09d6c35b9
      https://github.com/llvm/llvm-project/commit/5d106f16b972884fb81c7dac338eeeb09d6c35b9
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M compiler-rt/lib/tsan/rtl/tsan_platform.h
    M compiler-rt/lib/tsan/rtl/tsan_platform_linux.cpp

  Log Message:
  -----------
  tsan: remove indirection when selecting the active mapping

Currently there are 2 levels when selecting the active mapping:
the branchy ifdef tree + another ifdef tree in SelectMapping.
Moreover, there is an additional indirection for some platforms
via HAS_48_BIT_ADDRESS_SPACE define. This makes already complex
logic even more complex and almost impossible to read.
Remove one level of indirection and define the active mapping
in SelectMapping.

Depends on D107742.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D107743




More information about the All-commits mailing list