[all-commits] [llvm/llvm-project] 2ced1f: [OpenMP][NFC] Simplify targetDataEnd conditions fo...
Joel E. Denny via All-commits
all-commits at lists.llvm.org
Tue Aug 10 09:34:08 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 2ced1f338ae05260b01d9293e9dba27b90a2bfed
https://github.com/llvm/llvm-project/commit/2ced1f338ae05260b01d9293e9dba27b90a2bfed
Author: Joel E. Denny <jdenny.ornl at gmail.com>
Date: 2021-08-10 (Tue, 10 Aug 2021)
Changed paths:
M openmp/libomptarget/src/omptarget.cpp
Log Message:
-----------
[OpenMP][NFC] Simplify targetDataEnd conditions for CopyMember
targetDataEnd and targetDataBegin compute CopyMember/copy differently,
and I don't see why they should. This patch eliminates one of those
differences by making a simplifying NFC change to targetDataEnd.
The change is NFC as follows. The change only affects the case when
`!UNIFIED_SHARED_MEMORY || HasCloseModifier`. In that case, the
following points are always true:
* The value of CopyMember is relevant later only if DelEntry = false.
* DelEntry = false only if one of the following is true:
* IsLast = false. In this case, it's always true that CopyMember
= false = IsLast.
* `MEMBER_OF && !PTR_AND_OBJ` is true. In this case, CopyMember =
IsLast.
* Thus, if CopyMember is relevant, CopyMember = IsLast.
Reviewed By: grokos
Differential Revision: https://reviews.llvm.org/D105990
More information about the All-commits
mailing list