[all-commits] [llvm/llvm-project] 3bf779: [clangd] Strip mutliple arch options

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3bf77980d934c4aa383e4ea9a9a5de86598bea9b
      https://github.com/llvm/llvm-project/commit/3bf77980d934c4aa383e4ea9a9a5de86598bea9b
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp

  Log Message:
  -----------
  [clangd] Strip mutliple arch options

This patch strips all the arch options in case of multiple ones. As it
results in multiple compiler jobs, which clangd cannot handle.

It doesn't pick any over the others as it is unclear which one the user wants
and defaulting to host architecture seems less surprising. Users also have the
ability to explicitly specify the architecture they want via clangd config
files.

Fixes https://github.com/clangd/clangd/issues/827.

Differential Revision: https://reviews.llvm.org/D107634


  Commit: 79c2616d315f54d72bcdeebb6576c84be7b585d8
      https://github.com/llvm/llvm-project/commit/79c2616d315f54d72bcdeebb6576c84be7b585d8
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp

  Log Message:
  -----------
  [clangd] Canonicalize inputs provided with `--`

We already strip all the inputs provided without `--`, this patch also
handles the cases with `--`.

Differential Revision: https://reviews.llvm.org/D107637


Compare: https://github.com/llvm/llvm-project/compare/02b1c3f0529e...79c2616d315f