[all-commits] [llvm/llvm-project] ae1a2a: [NFC][MLGO] Make logging more robust

[Mircea Trofin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae1a2a09e41ee7464e785e8925f360f256d0eaca
      https://github.com/llvm/llvm-project/commit/ae1a2a09e41ee7464e785e8925f360f256d0eaca
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/Utils/TFUtils.h
    M llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
    M llvm/lib/Analysis/TFUtils.cpp
    M llvm/unittests/Analysis/TFUtilsTest.cpp

  Log Message:
  -----------
  [NFC][MLGO] Make logging more robust

1) add some self-diagnosis (when asserts are enabled) to check that all
features have the same nr of entries

2) avoid storing pointers to mutable fields because the proto API
contract doesn't actually guarantee those stay fixed even if no further
mutation of the object occurs.

Differential Revision: https://reviews.llvm.org/D107594