[all-commits] [llvm/llvm-project] 2b89f4: [LLDB][GUI] Refactor form drawing using subsurfaces

[Omar Emara via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b89f40a411cb9717232df61371b24d73ae84cb8
      https://github.com/llvm/llvm-project/commit/2b89f40a411cb9717232df61371b24d73ae84cb8
  Author: Omar Emara <mail at OmarEmara.dev>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [LLDB][GUI] Refactor form drawing using subsurfaces

This patch adds a new method SubSurface to the Surface class. The method
returns another surface that is a subset of this surface. This is
important to further abstract away drawing from the ncurses objects. For
instance, fields could previously be drawn on subpads only but can now
be drawn on any surface. This is needed to create the file search
dialogs and similar functionalities.

There is an opportunity to refactor window drawing in general using
surfaces, but we shall consider this separately later.

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D107182