[all-commits] [llvm/llvm-project] 16605a: [NFC][Codegen][X86] Add testcase that hanged after...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Thu Aug 5 10:38:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 16605aea844060c2973df079c9f91650132c099d
      https://github.com/llvm/llvm-project/commit/16605aea844060c2973df079c9f91650132c099d
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M llvm/test/CodeGen/X86/oddshuffles.ll

  Log Message:
  -----------
  [NFC][Codegen][X86] Add testcase that hanged after D107009

>From Benjamin Kramer @ https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20210802/945642.html


  Commit: c0586ff05dd08e4cbfc6fb7881274d8d89913463
      https://github.com/llvm/llvm-project/commit/c0586ff05dd08e4cbfc6fb7881274d8d89913463
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [NFC][X86] combineX86ShuffleChain(): hoist Mask variable higher up

Having `NewMask` outside of an if and rebinding `BaseMask` `ArrayRef`
to it is confusing. Instead, just move the `Mask` vector higher up,
and change the code that earlier had no access to it but now does
to use `Mask` instead of `BaseMask`.

This has no other intentional changes.

This is a recommit of 35c0848b570214ed2b2d96cca4dd62bb7ae725cd,
that was reverted to simplify reversion of an earlier change.


Compare: https://github.com/llvm/llvm-project/compare/9854f2f30f84...c0586ff05dd0


More information about the All-commits mailing list