[all-commits] [llvm/llvm-project] c020be: [lldb] Use a struct to pass function search option...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Aug 5 10:18:41 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c020be17ce0a43c32554585e1075627769f364f3
      https://github.com/llvm/llvm-project/commit/c020be17ce0a43c32554585e1075627769f364f3
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M lldb/include/lldb/Core/Module.h
    M lldb/include/lldb/Core/ModuleList.h
    M lldb/source/API/SBModule.cpp
    M lldb/source/API/SBTarget.cpp
    M lldb/source/Breakpoint/BreakpointResolverName.cpp
    M lldb/source/Commands/CommandCompletions.cpp
    M lldb/source/Commands/CommandObjectDisassemble.cpp
    M lldb/source/Commands/CommandObjectSource.cpp
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Core/Module.cpp
    M lldb/source/Core/ModuleList.cpp
    M lldb/source/Core/SourceManager.cpp
    M lldb/source/Expression/IRExecutionUnit.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    M lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp

  Log Message:
  -----------
  [lldb] Use a struct to pass function search options to Module::FindFunction

Rather than passing two booleans around, which is especially error prone
with them being next to each other, use a struct with named fields
instead.

Differential revision: https://reviews.llvm.org/D107295


  Commit: a46bcc60e52fe080ee87af1788e8cdc00f9c035f
      https://github.com/llvm/llvm-project/commit/a46bcc60e52fe080ee87af1788e8cdc00f9c035f
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M lldb/source/Expression/IRExecutionUnit.cpp

  Log Message:
  -----------
  [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

This patch refactors IRExecutionUnit::FindInSymbols. It eliminates a few
potential pitfalls and tries to be more explicit about the state carried
between symbol resolution attempts.

Differential revision: https://reviews.llvm.org/D107206


Compare: https://github.com/llvm/llvm-project/compare/a756239e7278...a46bcc60e52f


More information about the All-commits mailing list