[all-commits] [llvm/llvm-project] 976bd2: [llvm-ar] Fix for handling thin archive with SYM64...

[Hongtao Yu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 976bd2361237f2fafc736d26dc78d1b95cd80d94
      https://github.com/llvm/llvm-project/commit/976bd2361237f2fafc736d26dc78d1b95cd80d94
  Author: Ramesh Peri <rvperi at fb.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M llvm/lib/Object/Archive.cpp
    M llvm/test/Object/archive-symtab.test

  Log Message:
  -----------
  [llvm-ar] Fix for handling thin archive with SYM64 and a test case for it

WHen thin archives are created which have symbol table of type SYM64 then all the tools will not work since they cannot read the files properly.
One can reproduce the problem as follows:
1. Take a hello world program and create an archive out of it. The SYM64_THRESHOLD=0 will force the generation of SYM64 symbol table.
    clang -c hello.cpp
    SYM64_THRESHOLD=0 llvm-ar crsT mylib.a hello.o
2. Now try to use any of the tools on this mylib.a and it will fail.
    llvm-nm -M mylib.a

THis fix will eliminate these failures. A regression test is created in llvm/test/Object/archive-symtab.test

Reviewed By: MaskRay, Ramesh

Differential Revision: https://reviews.llvm.org/D107322