[all-commits] [llvm/llvm-project] 530ea2: Correct a lot of diagnostic wordings for the driver

Aaron Ballman via All-commits all-commits at lists.llvm.org
Thu Aug 5 04:05:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 530ea28fefc4652823a187a149e8001cbf4af18f
      https://github.com/llvm/llvm-project/commit/530ea28fefc4652823a187a149e8001cbf4af18f
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticDriverKinds.td
    M clang/lib/Driver/ToolChains/Cuda.cpp
    M clang/test/Driver/aarch64-outliner.c
    M clang/test/Driver/aix-object-mode.c
    M clang/test/Driver/amdgpu-invalid-target-id.s
    M clang/test/Driver/amdgpu-openmp-system-arch-fail.c
    M clang/test/Driver/arm-thumb-only-cores.c
    M clang/test/Driver/cl-inputs.c
    M clang/test/Driver/cl-options.c
    M clang/test/Driver/clang_f_opts.c
    M clang/test/Driver/cuda-bad-arch.cu
    M clang/test/Driver/cuda-detect.cu
    M clang/test/Driver/cuda-omp-unsupported-debug-options.cu
    M clang/test/Driver/cuda-options-freebsd.cu
    M clang/test/Driver/cuda-options.cu
    M clang/test/Driver/cuda-version-check.cu
    M clang/test/Driver/defsym.s
    M clang/test/Driver/fuse-ld.c
    M clang/test/Driver/hip-inputs.hip
    M clang/test/Driver/hip-invalid-target-id.hip
    M clang/test/Driver/invalid-target-id.cl
    M clang/test/Driver/msp430-hwmult.c
    M clang/test/Driver/openmp-offload-gpu.c
    M clang/test/Driver/openmp-offload.c
    M clang/test/Driver/rocm-detect.cl
    M clang/test/Driver/rocm-detect.hip
    M clang/test/Driver/rocm-not-found.cl
    M clang/test/Frontend/invalid-cxx-abi.cpp
    M clang/test/Frontend/round-trip-cc1-args.c
    M clang/test/OpenMP/target_messages.cpp

  Log Message:
  -----------
  Correct a lot of diagnostic wordings for the driver

Clang diagnostics should not start with a capital letter or use
trailing punctuation (https://clang.llvm.org/docs/InternalsManual.html#the-format-string),
but quite a few driver diagnostics were not following this advice. This
corrects the grammar and punctuation to improve consistency, but does
not change the circumstances under which the diagnostics are produced.




More information about the All-commits mailing list