[all-commits] [llvm/llvm-project] 7529f0: D106035: Remove conditional compilation for WCHAR ...

Neal via All-commits all-commits at lists.llvm.org
Thu Aug 5 00:30:30 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7529f0e3e1427fea93a6a66a2aed5394710e5fb5
      https://github.com/llvm/llvm-project/commit/7529f0e3e1427fea93a6a66a2aed5394710e5fb5
  Author: Neal Sidhwaney <nealsid at users.noreply.github.com>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M lldb/cmake/modules/LLDBConfig.cmake
    M lldb/include/lldb/Host/Editline.h
    M lldb/source/Host/common/Editline.cpp

  Log Message:
  -----------
  D106035: Remove conditional compilation for WCHAR support in libedit

This change moves to using narrow character types and libedit APIs in
Editline, because those are the same types that the rest of LLVM/LLDB
uses, and it's generally considered better practice to use UTF-8
encoded in char than it is to use wider characters. However, for
character input, the change leaves in using a wchar to enable input of
multi-byte characters.

Differential Revision: https://reviews.llvm.org/D106035




More information about the All-commits mailing list