[all-commits] [llvm/llvm-project] 4ae335: [clang] fix concepts crash on substitution failure...

[Matheus Izvekov via All-commits]

  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ae33534bd8c52c4f054bb4676632c37f49f56b2
      https://github.com/llvm/llvm-project/commit/4ae33534bd8c52c4f054bb4676632c37f49f56b2
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2021-08-03 (Tue, 03 Aug 2021)

  Changed paths:
    M clang/lib/Sema/SemaConcept.cpp
    M clang/test/CXX/temp/temp.constr/temp.constr.normal/p1.cpp

  Log Message:
  -----------
  [clang] fix concepts crash on substitution failure during normalization

When substitution failed on the first constrained template argument (but
only the first), we would assert / crash. Checking for failure was only
being performed from the second constraint on.

This changes it so the checking is performed in that case,
and the code is also now simplified a little bit to hopefully
avoid this confusion.

Signed-off-by: Matheus Izvekov <mizvekov at gmail.com>

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D106907